don't ICE on higher ranked hidden types #113575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
ci is broken for unrelated reasons 😓 |
lcnr
reviewed
Jul 17, 2023
There was a problem hiding this comment.
two thoughts:
- the
boolis unused by the only caller, can change the return type to(). - can you add a comment that this only adds the member constraints to the region graph and that we don't check them here but instead in
check_member_constraintsafter the region graph has been computed?
oli-obk
force-pushed
the
opaque-hrtb-ice
branch
from
0e773f5 to
d55522a
Compare
|
I rebased, blessed and addressed the review comment @bors r=lcnr |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (03181e0): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 649.353s -> 649.27s (-0.01%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't allow more code to compile, only replaces the ICE with a nicer error message.
Fixes #97098.
Fixes #97099.
Fixes #108399
Fixes #104196
Fixes #113481
Fixes #103186
Fixes #100818
r? @lcnr (because you showed interest in #100503 :)